Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rafiki version image from Chart.yaml #41

Open
golobitch opened this issue Sep 22, 2024 · 0 comments · May be fixed by #44
Open

Use rafiki version image from Chart.yaml #41

golobitch opened this issue Sep 22, 2024 · 0 comments · May be fixed by #44
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@golobitch
Copy link
Contributor

Thanks for taking the time to file a feature request! Please fill out this form as completely as possible.

Note that feature requests will be converted to the GitHub Discussions "Ideas" section.

Feature Request

Instead of using image version from values.yaml, use it from Chart.yaml.

appVersion should be the image version.
If image.tag or image.digest is specified in values.yaml, then use that.

Default should be appVersion from Chart.yaml

This is the relevant piece of code

@golobitch golobitch added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Sep 22, 2024
@devcer devcer linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant