Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply inflation hook is wrong #1210

Open
gregdhill opened this issue Dec 5, 2023 · 0 comments
Open

Supply inflation hook is wrong #1210

gregdhill opened this issue Dec 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@gregdhill
Copy link
Member

Describe the bug
We cannot call EscrowAnnuity::update_reward_per_block() because the escrow account also contains rewards already distributed to participants. We do the calculation rewardPerBlock = totalBalance / emissionPeriod where totalBalance should be the total amount for that emissionPeriod but is actually the balance of EscrowAnnuityAccount which also includes unclaimed tokens already distributed.

Expected behavior
We should calculate this value based on the inflation amount sent to the escrow account.

Additional context
We rectified the token distribution on Interlay and Kintsugi here:
@gregdhill gregdhill added the bug Something isn't working label Dec 5, 2023
@nud3l nud3l added this to Backlog Dec 5, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Backlog
Status: New 🆕
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregdhill