Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number displayed is wrong #1206

Open
Luca-Poggi opened this issue Nov 5, 2023 · 1 comment
Open

Version number displayed is wrong #1206

Luca-Poggi opened this issue Nov 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Luca-Poggi
Copy link

Describe the bug
When compiling from source the last version release v1.25.3, the version displayed in the binary and also in the telemetry is wrong (but the reference to the commit number is correct).

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://github.com/interlay/interbtc
  2. cd interbtc
  3. git checkout 1.25.3
  4. cargo build --release

Expected behavior
cd target/release
./interbtc-parachain --version
interbtc-parachain 1.25.3-b5e8e7ec614

instead I get:
interbtc-parachain 1.2.0-b5e8e7ec614

Version / Commit (e.g. 1.0.0):
v1.25.3

Additional context
The last part "b5e8e7ec614" relative to v1.25.3 is correct but not the version number!

@Luca-Poggi Luca-Poggi added the bug Something isn't working label Nov 5, 2023
@nud3l nud3l added this to Backlog Nov 5, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Nov 5, 2023
@gregdhill
Copy link
Member

This comes from the Substrate build script here which uses CARGO_PKG_VERSION - read from the package Cargo.toml file. We tend not to update this manually since we don't publish the crates anywhere but we do inject the tag in the CI for a release here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: New 🆕
Development

No branches or pull requests

2 participants