Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for request body which is not Hash #220

Open
KentaYoshitani opened this issue Apr 16, 2019 · 3 comments · May be fixed by #361
Open

No support for request body which is not Hash #220

KentaYoshitani opened this issue Apr 16, 2019 · 3 comments · May be fixed by #361
Labels
middleware

Comments

@KentaYoshitani
Copy link
Member

As commented on
https://github.com/interagent/committee/blob/master/lib/committee/request_unpacker.rb#L81-L87

No support for request body which is Array/Int/String (not Hash) and raise error Invalid JSON input. Require object with parameters as keys.

Want to support these not Hash request body
@ryu-sato
Copy link

ryu-sato commented Jun 8, 2022

Thanks for useful committee.

Is there any progress on this issue? @ota42y

I'm thinking to commit as long as you have a plan to deal with it.
Any plans or milestones?

@makdad
Copy link
Contributor

makdad commented Jul 19, 2022

Just wanted to add that this affects me as well. Happy to participate in a solution.

@ryu-sato ryu-sato linked a pull request Jul 24, 2022 that will close this issue
Open
@ryu-sato
Copy link

I didn't know plan or milestone how to resolve this issue, but I created a PR for discussion.

Would anyone be willing to review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/support non hash value in request body ryu-sato/committee
4 participants
@makdad @ota42y @KentaYoshitani @ryu-sato