Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcm-sensor-server generated grafana dashboard uses unsupported grafana plugins #730

Closed
vimalk78 opened this issue Apr 30, 2024 · 6 comments · Fixed by #732
Closed

pcm-sensor-server generated grafana dashboard uses unsupported grafana plugins #730

vimalk78 opened this issue Apr 30, 2024 · 6 comments · Fixed by #732

Comments

@vimalk78
Copy link
Contributor

grafana dashboard returned by pcm-sensor-server contains elements which are deprecated by latest grafana.

Need to useTimeSeries instead of Graph which is older way

image

image

@rdementi
Copy link
Contributor

thanks for opening the issue. Let us know if you able to submit a pull request. If not we will address it asap

@ogbrugge
Copy link
Contributor

If you edit the panel it will propose a conversion. Accept the conversion, look at the difference in the Grafana xml, then modify the Grafana generator to use the converted code. Should not be too hard if you know a little scripting.

@rdementi
Copy link
Contributor

it turned out to be easier than I thought:

diff --git a/src/dashboard.cpp b/src/dashboard.cpp
index 97a827f..62c7d2e 100644
--- a/src/dashboard.cpp
+++ b/src/dashboard.cpp
@@ -325,7 +325,7 @@ public:
         "sort": 0,
         "value_type": "individual"
       },
-      "type": "graph",
+      "type": "timeseries",
       "xaxis": {
         "buckets": null,
         "mode": "time",

@vimalk78
Copy link
Contributor Author

i also thought of the same changes, + perhaps change class name from GraphPanel to TimeSeriesPanel ?
I can submit a PR.

@rdementi
Copy link
Contributor

i also thought of the same changes, + perhaps change class name from GraphPanel to TimeSeriesPanel ? I can submit a PR.

that would be awesome

@vimalk78
Copy link
Contributor Author

vimalk78 commented May 2, 2024

PR for fix: #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants