Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill Knowhow: Refining skills #172

Open
2 tasks
obuzek opened this issue Mar 7, 2024 · 4 comments
Open
2 tasks

Skill Knowhow: Refining skills #172

obuzek opened this issue Mar 7, 2024 · 4 comments
Labels
good-first-issue Good for newcomers

Comments

@obuzek
Copy link
Contributor

obuzek commented Mar 7, 2024

We need better documentation on ensuring that the skills you contribute will actually improve the model.

People have reported their generate_.jsonl and train_.jsonl files (as a result of running lab generate) contain relatively inaccurate alternate instruction suggestions. We'll likely get a better skill tree if people learn to look at these outputs, and refine the verbiage of their skills until they're getting strong answers from the teacher model (the one you load up with lab serve before you run lab generate).

@xukai92's commentary:

  • how easy/hard to get good synthetic data depends on the q/a themselves. perhaps rewriting or rephrasing could help
  • there are some improvements on the method itself we will deploy in the next few days
  • potentially switch the model used by lab generate could be helpful, but it requires a better machine. all it needs is an endpoint but instructions to be added (instructions to use a stronger teacher model instructlab#398)
  • if you can load mixtral-8x7b-v0.1.Q4_K_M.gguf from https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF in lab serve and document how to do this it would be very helpful for others

Tasks

  • Add Kai's commentary to the skill info docs
  • Suggest in both skill development and triage info docs that changing your wording and rerunning the skill until your .jsonl output has improved will be more beneficial to the model
@obuzek obuzek added good-first-issue Good for newcomers triage-meta labels Mar 7, 2024
@obuzek
Copy link
Contributor Author

obuzek commented Mar 7, 2024

See also instructlab/instructlab#398

@code2automate
Copy link
Contributor

We need better documentation on ensuring that the skills you contribute will actually improve the model.

People have reported their generate_.jsonl and train_.jsonl files (as a result of running lab generate) contain relatively inaccurate alternate instruction suggestions. We'll likely get a better skill tree if people learn to look at these outputs, and refine the verbiage of their skills until they're getting strong answers from the teacher model (the one you load up with lab serve before you run lab generate).

@xukai92's commentary:

  • how easy/hard to get good synthetic data depends on the q/a themselves. perhaps rewriting or rephrasing could help
  • there are some improvements on the method itself we will deploy in the next few days
  • potentially switch the model used by lab generate could be helpful, but it requires a better machine. all it needs is an endpoint but instructions to be added (instructions to use a stronger teacher model cli#398)
  • if you can load mixtral-8x7b-v0.1.Q4_K_M.gguf from https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF in lab serve and document how to do this it would be very helpful for others

Tasks

  • Add Kai's commentary to the skill info docs
  • Suggest in both skill development and triage info docs that changing your wording and rerunning the skill until your .jsonl output has improved will be more beneficial to the model

Hi @obuzek

It would be helpful for the first time contributers if you could please provide references to the docs you've mentioned above (skill info, skill development & triage info docs)

I've taken this opportunity to provide the references, kindly update if they are incorrect

skill info doc : SKILLS_GUIDE.md
skill development doc : SKILLS_GUIDE.md
triage info doc : skills-triage.md

@obuzek
Copy link
Contributor Author

obuzek commented Mar 15, 2024

The Community Learning Guide covers some relevant topics, but not yet this one.

Automatic generation in response to PRs is getting added soon, which may help people with this.

Leaving this open since this remains relevant information.

@luke-inglis luke-inglis added triage-uncertain triager is uncertain which can be for a variety of reasons and removed triage-meta labels Apr 12, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Jun 12, 2024
@juliadenham juliadenham removed the stale stale-bot has marked you as stale label Aug 21, 2024
@jjasghar jjasghar removed the triage-uncertain triager is uncertain which can be for a variety of reasons label Aug 22, 2024
@obuzek obuzek closed this as completed Aug 23, 2024
@obuzek obuzek reopened this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants