Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent meta-variable naming in the parser #77

Open
jstolarek opened this issue Aug 1, 2024 · 0 comments
Open

Inconsistent meta-variable naming in the parser #77

jstolarek opened this issue Aug 1, 2024 · 0 comments
Labels
UI/UX CLI interface and user experience

Comments

@jstolarek
Copy link
Contributor

jstolarek commented Aug 1, 2024

Variables in the parser use inconsistent naming scheme. For example, for the reserve-deposit command:

--deposit-reserve-asset ASSET-SCRIPT-HASH
--reserve-asset-name RESERVE_ASSET_NAME

Notice how one variable uses dashes to delimit words, whereas other uses underscores. The dashes seem to be an oversight from the work on native token reserve management. The default we have always used are underscores and we should fix the parser to consistently use underscores in the metavariables.


IOG Jira: https://input-output.atlassian.net/browse/ETCM-8066

@jstolarek jstolarek added the UI/UX CLI interface and user experience label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX CLI interface and user experience
Projects
None yet
Development

No branches or pull requests

1 participant