Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Unsafe refactor CI errors #44

Open
kpinter-iohk opened this issue May 8, 2024 · 4 comments
Open

Investigate Unsafe refactor CI errors #44

kpinter-iohk opened this issue May 8, 2024 · 4 comments
Assignees
Labels
optimization Improving execution speed and costs

Comments

@kpinter-iohk
Copy link
Contributor

kpinter-iohk commented May 8, 2024

Some PRs that refactor scripts to use Unsafe field getters to optimize script size have odd errors in their CI runs.

  1. https://github.com/input-output-hk/trustless-sidechain/pull/791
    CI failure (link):
error: builder for '/nix/store/0a639walyssna14zayj91i1i7w0nxba3-trustless-sidechain-ctl-check.drv' failed with exit code 1;
       last 25 log lines:
       >     at <anonymous> (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/.spago/cardano-transaction-lib/b7e8d396711f95e7a7b755a2a7e7089df712aaf5/src/Contract/Monad.purs:126:22)
       >     at <anonymous> (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/s8z5r0l2d0hsybnpzckrg8g7vljhws0p-trustless-sidechain-ctl-src/src/TrustlessSidechain/Effects/Contract.purs:102:10)
       >     at <anonymous> (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/.spago/transformers/v5.2.0/src/Control/Monad/Reader/Trans.purs:69:3)
       >     at run (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:278:22)
       >     at /nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:348:19
       >     at drain (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:120:9)
       >     at Object.enqueue (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:141:11)
       >     at /nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:339:27
       > 
       > In "Plutip integration tests":
       >   In "Claiming and burning FUEL tokens using proxy mechanism":
       >     In "Multiple minting and burning, updating policies in between":
       >       Error: (UnknownContractError "A transaction error occurred: in the context of submit: Failed to submit tx:\n(ClientOtherError [{\"executionUnitsTooLarge\":{\"maximumExecutionUnits\":{\"memory\":10000000,\"steps\":10000000000},\"actualExecutionUnits\":{\"memory\":10597098,\"steps\":3319624448}}}])")
       >     at exports.error (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Exception/foreign.js:8:10)
       >     at Object.$$throw (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/.spago/exceptions/v5.0.0/src/Effect/Exception.purs:82:9)
       >     at <anonymous> (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/.spago/cardano-transaction-lib/b7e8d396711f95e7a7b755a2a7e7089df712aaf5/src/Contract/Monad.purs:126:22)
       >     at <anonymous> (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/s8z5r0l2d0hsybnpzckrg8g7vljhws0p-trustless-sidechain-ctl-src/src/TrustlessSidechain/Effects/Contract.purs:102:10)
       >     at <anonymous> (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/.spago/transformers/v5.2.0/src/Control/Monad/Reader/Trans.purs:69:3)
       >     at run (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:278:22)
       >     at /nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:348:19
       >     at drain (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:120:9)
       >     at Object.enqueue (/nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:141:11)
       >     at /nix/store/kwf2988phb8spwlhmr8sv21ym62hbqy5-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:339:27
       > 
       > 
       For full logs, run 'nix log /nix/store/0a639walyssna14zayj91i1i7w0nxba3-trustless-sidechain-ctl-check.drv'.
  1. https://github.com/input-output-hk/trustless-sidechain/pull/793
    CI failure (link):
error: builder for '/nix/store/fvyi373bmyv8jvr8krl7zn0dafdhgkwr-trustless-sidechain-ctl-check.drv' failed with exit code 1;
       last 25 log lines:
       >     at <anonymous> (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/.spago/cardano-transaction-lib/b7e8d396711f95e7a7b755a2a7e7089df712aaf5/src/Internal/Plutip/Server.purs:457:11)
       >     at <anonymous> (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/.spago/either/v5.0.0/src/Data/Either.purs:209:1)
       >     at <anonymous> (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/.spago/cardano-transaction-lib/b7e8d396711f95e7a7b755a2a7e7089df712aaf5/src/Internal/Plutip/Server.purs:457:11)
       >     at run (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:278:22)
       >     at /nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:348:19
       >     at drain (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:120:9)
       >     at Object.enqueue (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:141:11)
       >     at /nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:339:27
       > 
       > In "Plutip integration tests":
       >   In "MerkleRootChaining tests":
       >     In "Merkle root chaining scenario 1":
       >       Error: (UnknownContractError "A transaction error occurred: in the context of submit: Failed to submit tx:\n(ClientOtherError [{\"executionUnitsTooLarge\":{\"maximumExecutionUnits\":{\"memory\":10000000,\"steps\":10000000000},\"actualExecutionUnits\":{\"memory\":10376564,\"steps\":4851318479}}}])")
       >     at exports.error (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Exception/foreign.js:8:10)
       >     at Object.$$throw (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/.spago/exceptions/v5.0.0/src/Effect/Exception.purs:82:9)
       >     at <anonymous> (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/.spago/cardano-transaction-lib/b7e8d396711f95e7a7b755a2a7e7089df712aaf5/src/Contract/Monad.purs:126:22)
       >     at <anonymous> (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/37lmy7a758f3izgnv2hypvyng5sgn1bv-trustless-sidechain-ctl-src/src/TrustlessSidechain/Effects/Contract.purs:102:10)
       >     at <anonymous> (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/.spago/transformers/v5.2.0/src/Control/Monad/Reader/Trans.purs:69:3)
       >     at run (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:278:22)
       >     at /nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:348:19
       >     at drain (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:120:9)
       >     at Object.enqueue (/nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:141:11)
       >     at /nix/store/mvp84bi2nsjybhvih5vknygnk71k1vdm-trustless-sidechain-ctl/output/Effect.Aff/foreign.js:339:27
       > 
       > 
       For full logs, run 'nix log /nix/store/fvyi373bmyv8jvr8krl7zn0dafdhgkwr-trustless-sidechain-ctl-check.drv'.

IOG Jira: https://input-output.atlassian.net/browse/ETCM-7401

@jstolarek
Copy link
Contributor

The first error is almost certainly bogus - we've seen those happen a lot. The other two, however, look like legitimate errors.

@kpinter-iohk
Copy link
Contributor Author

The first error is almost certainly bogus - we've seen those happen a lot. The other two, however, look like legitimate errors.

Re-ran CI and it turned green, deleted first PR from description.

@anitajov
Copy link

@kpinter-iohk Should this be closed based on your last comment? Thank you!

@kpinter-iohk
Copy link
Contributor Author

@anitajov There are still two legitimate errors that need to be investigated.

@gilligan gilligan transferred this issue from another repository Jul 15, 2024
@jstolarek jstolarek added the optimization Improving execution speed and costs label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Improving execution speed and costs
Projects
None yet
Development

No branches or pull requests

3 participants