Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ [TASK] : Add support for secrets #77

Open
Tracked by #168
jmgilman opened this issue Nov 2, 2023 · 0 comments
Open
Tracked by #168

🛠️ [TASK] : Add support for secrets #77

jmgilman opened this issue Nov 2, 2023 · 0 comments
Assignees

Comments

@jmgilman
Copy link
Collaborator

jmgilman commented Nov 2, 2023

Currently, it's not possible for arbitrary secrets to be passed to a target. This is because it's impossible for the CI to distinguish when a target needs secrets, what those secrets are, and where to find them.

Luckily, secrets are always passed as a flag to the RUN command. This means it's possible to scan and extract the names of secrets being used in a given target. We can combine this with the assumption that all secrets must be defined as GitHub Action secrets (with the exact same name used in the target) to make it possible to arbitrarily pass the correct secrets.

The scanning will be implemented via the CLI and called before executing the target. The run action will have to be modified to use the GitHub API to fetch the secrets and dynamically set environment variables before running the earthly CLI.

@jmgilman jmgilman self-assigned this Nov 2, 2023
@minikin minikin moved this to 🔖 Ready in Catalyst Nov 8, 2023
@stevenj stevenj changed the title Add support for secrets 🛠️ [TASK] : Add support for secrets Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant