-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the use of await sodium.ready #1529
Comments
Hey @jinglescode, would we require consumer to await it separately/globally then, or do you have some other ideas? |
if reference strica and harmonic implementation as reference, and dont use libsodium lib, might be able to remove async await entirely. |
@mkazlauskas The existing approach seems due to the way |
Thanks for the report guys, we will look into this. We should be able to remove the async from these functions |
Describe the feature you'd like
To make keys functions non-async.
Rewrite
packages/crypto/src/Bip32/Bip32PrivateKey.ts
andpackages/crypto/src/Bip32/Bip32PublicKey.ts
to remove async whenderive(derivationIndices: number[]): Bip32PublicKey
andtoPublic(): Bip32PublicKey
Describe alternatives you've considered
The text was updated successfully, but these errors were encountered: