Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise / Pass Through DCMTK Exceptions #44

Open
joshuatz opened this issue Jun 28, 2022 · 0 comments
Open

Raise / Pass Through DCMTK Exceptions #44

joshuatz opened this issue Jun 28, 2022 · 0 comments

Comments

@joshuatz
Copy link
Contributor

joshuatz commented Jun 28, 2022

As noted in #43 and related discussions, DCMTK can often return a zero exit code, even if the command has essentially failed, but puts the actual error code in the returned message. Now that we are extracting the error codes, we should pass them through to consumers as Exceptions.

As noted in this comment, this would represent a breaking change and would necessitate a minor (at least) version bump (along with proper documentation, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant