LionCalendar: Enable overriding previous & next button's icon template #1953
Closed
ghost
started this conversation in
Open for contributions
Replies: 1 comment 1 reply
-
|
@barni52 sounds like a good idea. go ahead and create a PR i would say. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Yep, submitted a pull request here (#1954) :) |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The LionCalendar component currently doesn't allow the changing of the previous and next button's icons without modifying the protected __renderPreviousButton and __renderNextButton methods.
My proposed solution would be to extract the arrows into two overridable methods called _previousIconTemplate and _nextIconTemplate respectively. This would decouple the icons from the underlying logic of the buttons.
Beta Was this translation helpful? Give feedback.
All reactions