Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording ErrorResponse in Connector Client #66

Open
arlandism opened this issue Jan 6, 2022 · 0 comments
Open

Recording ErrorResponse in Connector Client #66

arlandism opened this issue Jan 6, 2022 · 0 comments

Comments

@arlandism
Copy link

Hello! Thanks for maintaining this awesome library. It's been very productive for our team.

I stumbled on something while using it. When requests are made using the connector client (here, for example), the library is only checking whether the response is a 2xx status code and returning a custom error if not. There's some Microsoft documentation that indicates the presence of an ErrorResponse object in the response body and it would be nice to have that for debugging purposes.

It would be pretty easy to integrate into the HtErr field of theHTTPError type. I'm happy to submit a pull request for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant