You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have somehow ended up with several different types with similar names holding similar but not identical information, which is quite confusing for everybody (me included).
Let's review those and see if we can deduplicate them or find better names for each of them:
There is also the Proposal trait, which is not actually implemented for any of those, but only for the concrete proposal type, which does not help with the confusion:
From the consensus point of view, we have a Value that is anything that is proposed and decided in consensus. I am not sure whether the extensions in the code are decided or just data exchanged "outside consensus" (not committed).
A Proposal is a Value with the metadata needed to the first round step of Tendermint. Namely, height, round, valid round, and some identification of the proposer process (can be just a signature).
It is not 100% clear to me whether the Proposal from the Tendermint protocol carries a "full" Value or an unique identifier of the proposed "full" Value. On Quint this is trivial, as id(v) = v, but implementation-wise this is super relevant.
We have somehow ended up with several different types with similar names holding similar but not identical information, which is quite confusing for everybody (me included).
Let's review those and see if we can deduplicate them or find better names for each of them:
malachite/code/crates/core-consensus/src/types.rs
Lines 44 to 50 in 55fc086
malachite/code/crates/core-consensus/src/types.rs
Lines 54 to 62 in 55fc086
malachite/code/crates/engine/src/host.rs
Lines 22 to 27 in 55fc086
There is also the
Proposal
trait, which is not actually implemented for any of those, but only for the concrete proposal type, which does not help with the confusion:malachite/code/crates/core-types/src/proposal.rs
Lines 6 to 28 in 55fc086
The text was updated successfully, but these errors were encountered: