Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Replace Node trait with more flexible solution or remove it altogether #701

Open
Tracked by #718
romac opened this issue Dec 18, 2024 · 0 comments
Open
Tracked by #718

code: Replace Node trait with more flexible solution or remove it altogether #701

romac opened this issue Dec 18, 2024 · 0 comments
Labels
application Related to building applications on top of Malachite code Code/implementation related P: high Priority: high
Milestone
Phase 5

Comments

@romac
Copy link
Member

romac commented Dec 18, 2024

The Node trait is clunky at best right now, as it hardcodes the app configuration type, enforces the loading of the private from a file (and therefore wouldn't support something like TMKMS), and contains a useless run method that is only useful for the test CLI crate.
@romac romac mentioned this issue Dec 18, 2024
Merged
2 tasks
@romac romac changed the title code: Revisit Node trait code: Replace Node trait with more flexible solution or remove altogether Dec 18, 2024
@romac romac changed the title code: Replace Node trait with more flexible solution or remove altogether code: Replace Node trait with more flexible solution or remove it altogether Dec 18, 2024
@romac romac added this to the Phase 5 milestone Dec 18, 2024
@romac romac added application Related to building applications on top of Malachite code Code/implementation related P: high Priority: high labels Dec 18, 2024
@romac romac mentioned this issue Dec 19, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
application Related to building applications on top of Malachite code Code/implementation related P: high Priority: high
Projects
None yet
Milestone
Phase 5
Development

No branches or pull requests
1 participant
@romac