Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split store codes into separate crate #126

Closed
Farhad-Shabani opened this issue Aug 25, 2023 · 0 comments · Fixed by #127
Closed

Split store codes into separate crate #126

Farhad-Shabani opened this issue Aug 25, 2023 · 0 comments · Fixed by #127

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

During my work on developing a mock Cosmos chain for the Hermes relayer-next (this issue), I observed that the current repository structure could potentially create circular dependencies for projects aiming to utilize store types and implementation. Additionally, this forces projects to include unnecessary library parts, even if they only need the store parts.

To address this, it is suggested we split the store code from the application and maintain it as a distinct crate.

This separation would also facilitate the development of a new mock module in ibc-rs. Consequently, to benefit from the AVL store implementation, we will only have to import the basecoin_store library without the need to rely on any application-related code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant