From 2204d1cd0050672aeea7a60532768b465a40fcd5 Mon Sep 17 00:00:00 2001
From: Mike Taylor <mike@indexdata.com>
Date: Wed, 5 Jul 2023 17:38:20 +0100
Subject: [PATCH] Move renderPaneFooter out into its own file

---
 src/settings/StorageForm.js      | 38 +++++---------------------------
 src/settings/renderPaneFooter.js | 36 ++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 33 deletions(-)
 create mode 100644 src/settings/renderPaneFooter.js

diff --git a/src/settings/StorageForm.js b/src/settings/StorageForm.js
index 86bda1e..6952fec 100644
--- a/src/settings/StorageForm.js
+++ b/src/settings/StorageForm.js
@@ -2,12 +2,13 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { useIntl, FormattedMessage } from 'react-intl';
 import arrayMutators from 'final-form-arrays';
-import { Button, Pane, PaneFooter, Row, Select, Checkbox, TextArea } from '@folio/stripes/components';
+import { Pane, Row, Select, Checkbox, TextArea } from '@folio/stripes/components';
 import { TitleManager } from '@folio/stripes/core';
 import stripesFinalForm from '@folio/stripes/final-form';
 import { isEqual } from 'lodash';
 import setFieldData from 'final-form-set-field-data'; // XXX do we need this?
 import { RCF, CF } from '../components/CF';
+import renderPaneFooter from './renderPaneFooter';
 
 
 function validate(values) {
@@ -42,47 +43,18 @@ const StorageForm = (props) => {
   };
   const types = ['inventoryStorage', 'solrStorage'].map(x => ({ value: x, label: x }));
 
-  function renderPaneFooter() {
-    return (
-      <PaneFooter
-        renderStart={(
-          <Button
-            buttonStyle="default mega"
-            id="clickable-cancel"
-            marginBottom0
-            onClick={onCancel}
-          >
-            <FormattedMessage id="stripes-components.cancel" />
-          </Button>
-        )}
-        renderEnd={(
-          <Button
-            buttonStyle="primary mega"
-            disabled={pristine || submitting}
-            id="clickable-update-harvestable"
-            marginBottom0
-            onClick={handleSubmit}
-            type="submit"
-          >
-            <FormattedMessage id="stripes-components.saveAndClose" />
-          </Button>
-        )}
-      />
-    );
-  }
-
   const title = props.initialValues.name;
 
   return (
     <Pane
       centerContent
       defaultWidth="60%"
-      footer={renderPaneFooter()}
-      id="pane-harvestable-form"
+      footer={renderPaneFooter(handleSubmit, onCancel, pristine, submitting)}
+      id="pane-storage-form"
       paneTitle={title}
     >
       <TitleManager record={title}>
-        <form id="form-course">
+        <form id="form-storage">
           <Row>
             <CF tag="id" xs={2} disabled />
             <CF tag="type" domain="storage" xs={2} component={Select} dataOptions={[noValue].concat(types)} required />
diff --git a/src/settings/renderPaneFooter.js b/src/settings/renderPaneFooter.js
new file mode 100644
index 0000000..36c66ad
--- /dev/null
+++ b/src/settings/renderPaneFooter.js
@@ -0,0 +1,36 @@
+import React from 'react';
+import { Button, PaneFooter } from '@folio/stripes/components';
+import { FormattedMessage } from 'react-intl';
+
+
+function renderPaneFooter(handleSubmit, onCancel, pristine, submitting) {
+  return (
+    <PaneFooter
+      renderStart={(
+        <Button
+          buttonStyle="default mega"
+          id="clickable-cancel"
+          marginBottom0
+          onClick={onCancel}
+        >
+          <FormattedMessage id="stripes-components.cancel" />
+        </Button>
+      )}
+      renderEnd={(
+        <Button
+          buttonStyle="primary mega"
+          disabled={pristine || submitting}
+          id="clickable-update-harvestable"
+          marginBottom0
+          onClick={handleSubmit}
+          type="submit"
+        >
+          <FormattedMessage id="stripes-components.saveAndClose" />
+        </Button>
+      )}
+    />
+  );
+}
+
+
+export default renderPaneFooter;