-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create merge()
to merge datasets
#75
Comments
I agree with the need of this functionality and that it is best supported by a function in Camtrap DP. The implementation details are to be discussed, but I'd prefer to tackle this after https://github.com/inbo/camtraptor/milestone/3 |
A logic request, definitely. I agree with @peterdesmet: it's better to add this functionality after the big refactoring. |
Just to have an idea (and planning the next analyses) -- what would be the timing for this new feature ? |
Agreed with @peterdesmet to add this functionality to v1 and to give it a higher priority. |
Suggested in camtraptor July 2023 coding sprint
|
merge()
to merge datasets
I have described the functionality in more detail at tdwg/camtrap-dp#380. I think the function should be called |
Task list by @sannegovaert:
|
Merge should also handle "additional resources". Currently only the additional resource of x are kept
I think that the cleanest solution is therefore to remove additional resources, with a warning that lists which ones are removed, see this code to find them: Line 42 in 8c4981e
In the tests, I would remove |
Could you prompt the user if they are named the same?
…On Thu, 17 Oct 2024, 15:07 Peter Desmet, ***@***.***> wrote:
Merge should also handle "additional resources". Currently only the
additional resource of x are kept
- Keeping both makes sense, but if they are named the same, we don't
know what to do
- Even if we keep them, they might contain identifiers that refer to
dep, med, obs which become invalid
I think that the cleanest solution is therefore to remove additional
resources, with a warning that lists which ones are removed, see this code
to find them:
https://github.com/inbo/camtrapdp/blob/8c4981e39ed56245630d6ed2a4ac66f282c84a59/R/print.R#L42
In the tests, I would remove individuals from x so you don't have to deal
with suppressWarnings() all the time.
—
Reply to this email directly, view it on GitHub
<#75 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALOW2O3WEUQRTL2IYCMDQETZ36ZABAVCNFSM6AAAAABIS4TZMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZGQ4TSMBSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
As in, ask for a decision? What options do you provide them? One alternative is to rename the additional resources by prefixes the dataset identifier (cf. the deployments). I would then do this for all resources, so you see where they came from). This doesn't prompt user and shouldn't trigger a warning. |
If they are named the same, ask the user to name the tables. I think there is value in being consistent with the deployments. |
Note by @peterdesmet: see #75 (comment) for recent thoughts.
Quite often we want to merge the exports of several research projects (more and more for multi-site research), all using Camtrap-DP as export format, mostly all resulting from agouti.
Though manually this can be done by using several times read_camtrap_dp and subsequently merging the different resulting csv-files, I was wondering if it would not be better to add a function to camtraptor that automatically
The text was updated successfully, but these errors were encountered: