Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird variable name C (printed C0) in QuantumLib.Complex.Cconj_opp #48

Open
letouzey opened this issue Oct 22, 2024 · 0 comments
Open

Comments

@letouzey
Copy link

Just a minor remark : QuantumLib.Complex.Cconj_opp uses a variable named capitalized C, which is unfortunate, since C is here the type of the complex numbers. Even if that doesn't prevent from using this lemma, could you rename this variable, for instance to uncapitalized c ? Currently, there's even more confusion when Check'ing Cconj_opp :

Check Cconj_opp.
(*Cconj_opp
     : forall C0 : C, (- C0) ^* = - C0 ^*
*)

Actually, Coq noticed the name clash ... and displays instead C0, i.e the zero of complex numbers ! (I guess it has something to
do with C0 being a notation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant