Issue with Donation Details Update

[8verstudio-Chua]

Hi there,

I've developed a module to programmatically create subscriptions, and the creation process has been successful. However, I encountered an issue when attempting to update the related donation's payment type and other details.

I utilized the following module as a reference for subscription creation: Subscription.php. Below is the relevant portion of my code:

<?php
// class-recurring-listener.php

use Give\Subscriptions\Models\Subscription;
use Give\Subscriptions\ValueObjects\SubscriptionPeriod;
use Give\Subscriptions\ValueObjects\SubscriptionMode;
use Give\Subscriptions\ValueObjects\SubscriptionStatus;
use Give\Framework\Support\ValueObjects\Money;

use Give\Donations\ValueObjects\DonationType;
....

private function handle_callback(){
....
....
if ($payment['status'] == 'paid') {
       // args for create subscription
        $timestamp = $payment['payment']['paid_on'];
        $createdAt = new DateTime('@' . $timestamp); // DateTime object for 'now
        $renewTimestamp = $payment['payment']['paid_on'] + 86400; // 86400 seconds = 1 day
        $renewsAt = new DateTime('@' . $renewTimestamp); // DateTime object for 'now

        
        $attributes = array(
          'donationFormId' => $form_id,
          'createdAt' => $createdAt,
          'renewsAt' => $renewsAt,
          'donorId' => $donorID,
          'period' => SubscriptionPeriod::DAY(),
          'frequency' => 1,
          'installments' => 0,
          'transactionId' => $payment['id'],
          'mode' => SubscriptionMode::LIVE(),
          'amount' => Money::fromDecimal($payment['payment']['amount'] / 100, 'MYR'),
          'feeAmountRecovered' => Money::fromDecimal(0, 'MYR'),
          'status' => SubscriptionStatus::ACTIVE(),
          'gatewaySubscriptionId' => $payment['id'],
          'gatewayId' => 'CHIP',
        );

        // create subscription with donation
        $subscription = Subscription::create($attributes);

        //update donation type to subscription and other details
        $give_payment = new Give_Payment($donation_id);
        if ($give_payment && $give_payment->ID > 0) {

          $give_payment->status         = 'publish';
          $give_payment->transaction_id = $payment['id'];
          $give_payment->type = DonationType::SUBSCRIPTION(); //this is not working
          $give_payment->subscriptionId = $subscription->id; // this is not working
          $give_payment->save();
        }
        give()->subscriptions->updateLegacyParentPaymentId($subscription->id, $donation_id);
 }

}

?>

As observed in the provided code, I utilized the $give_payment->type = DonationType::SUBSCRIPTION(); and $give_payment->subscriptionId = $subscription->id; lines, but it appears that these didn't update the relevant details in the donation.

Screenshot of the current donation result I have, image 1, image 2

I would greatly appreciate any guidance or assistance on this matter. Thank you!

[jonwaldstein]

Hey @8verstudio-Chua

You will want replace your usage of our legacy class Give_Payment with the Donation model as it looks like you are trying to use the donation model api with the legacy Give_Payment class which would not work.

Here's an example direction taken from your code:

//update donation type to subscription and other details
$donation = Donation::create([
    'amount' => $subscription->amount,
    'formId' => $subscription->donationFormId,
    'status' => DonationStatus::COMPLETE(),
    'transactionId' => $payment['id'],
    'type' => DonationType::SUBSCRIPTION(),
    'subscriptionId' => $subscription->id,
]);

give()->subscriptions->updateLegacyParentPaymentId($subscription->id, $donation->id)

[8verstudio-Chua]

Hi @jonwaldstein

Thank you for the advice. Ultimately, I had to utilize Donation::find() to retrieve the donation first before saving it with the relevant details. I encountered uncertainty regarding the timing of donation creation, as it occurred before proceeding to the payment gateway for payment. Nevertheless, the method is effective, and I will share the code below for reference.

        // create subscription with donation
        $subscription = Subscription::create($attributes);

        //find donation
        $donation = Donation::find($donation_id);
        $donation->type = DonationType::SUBSCRIPTION();
        $donation->subscriptionId = $subscription->id;
        $donation->status = DonationStatus::COMPLETE();

        // to save donation
        $donation->save();
        give()->subscriptions->updateLegacyParentPaymentId($subscription->id, $donation_id);

[jonwaldstein]

glad to hear!