feat(server): use the earliest date between file creation and modification timestamps when missing exif tags #14874
Conversation
alextran1502
changed the title
|
📖 Documentation deployed to pr-14874.preview.immich.app |
| this.logger.warn( | ||
| `No valid date found in exif tags from asset ${asset.id}, falling back to earliest timestamp between file creation and file modification`, | ||
| ); | ||
| // eslint-disable-next-line unicorn/prefer-math-min-max |
There was a problem hiding this comment.
Why not do Math.min(asset.fileModifiedAt, asset.fileCreatedAt)?
There was a problem hiding this comment.
Because it returns a number, but I can do new Date(Math.min(asset.fileModifiedAt, asset.fileCreatedAt)) instead if you prefer
There was a problem hiding this comment.
I'd prefer that, thanks!
There was a problem hiding this comment.
Sadly, ts linter reports it 😆
You have to choose the pill: the red or the green one ? 😄
There was a problem hiding this comment.
Date.valueOf() or Date.getTime() also work.
new Date(Math.min(asset.fileModifiedAt.valueOf(), asset.fileCreatedAt.valueOf()))There was a problem hiding this comment.
I don't want to take either pill and instead just use luxon lmao. Do you think that's overkill or would it make things nicely readable?
There was a problem hiding this comment.
Funny enough luxon's min/max functions require a DateTime instead of a Date, so a conversion is going to have to happen somewhere anyway, which means something like:
DateTime.min(DateTime.fromJSDate(asset.fileModifiedAt), DateTime.fromJSDate(asset.fileCreatedAt)).toJSDate()😅
…ation timestamps when missing exif tags
I also applied the date extraction for motion asset creation, tell me if I need to rollback this part, maybe it was wanted to not re-use
getDates.Closes #14857