Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the 'dynamics' and put all data in the trigger event tag (tupple api) #93

Open
jappeace opened this issue Oct 16, 2019 · 3 comments

Comments

@jappeace
Copy link
Contributor

jappeace commented Oct 16, 2019

I believe this idea was discussed in a PR: #78

Today I tried making this a reality but I ran out of time. I do have an approach to make this work: we construct in the servant interpreting part a function that will create a Req from the tag that peels of layers of the tupple. If we create the function like that it can turn the tag into a Req in one go, so we don't have to 'combine' data from different events.

I started doing this but everything blew up and I realized most code had to change to make this work.
It does become a lot neater though if you do it like this I think.

@jappeace
Copy link
Contributor Author

I'm working on this here: https://github.com/jappeace/servant-reflex/tree/tupple-api

@imalsogreg
Copy link
Owner

Thanks @jappeace ! I definitely like this approach. I have made some progress on it at https://github.com/imalsogreg/servant-reflex/tree/tuple-api-3 - may be work taking a look to see how I'm dealing with the nested tuples.

This approach has some confusing dark corners, but tuple-api-3 is very close to being releasable.

Happy to go instead with your thing, whether it's based on tuple-api-3 or not :)

@jappeace
Copy link
Contributor Author

I'll use your approach then if I can make it work.

I just need this asap.

For now I merged master into it: https://github.com/jappeace/servant-reflex/tree/tuple-api-3
I'll continue another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants