-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Most of the Functionality In The Paper #5
Comments
I noticed the same issue. I find this a bit misleading. Please at least inform us of this on the readthedocs page of the project -- not everyone is capable of examining the code in such detail as to notice the lack of e.g. preprocessing steps for the EDA pipeline. That said, it would also be marvellous to have the full functionality. Please consider continuing with this! |
@enniin, If you really need the functionality it all exists in various feature branches that have never been merged into master (or published on pypi). If you are using more than EDA, also note that there are problems with the ACC preprocessing and HRV preprocessing as well. For our work, my team ended up going with the Neurokit2 package. |
You have to load the data into numpy arrays before passing it to NeuroKit2. But yes, it does work with E4 wristband. That's what my lab uses. |
Thank you!! I think for this situation I will try to use the EDA-branch, though it does seem unmaintained -- there are some problems with getting it installed. (I guess I could make a pull request of it, as I managed to solve them, even if there's no maintainer to take them on board...) Thank you also for the tip on Neurokit2! It will be my second option. |
@hidaIgo Yeah, totally, What E4 sensor are you interested in? I assume EDA and BVP? |
You just have to split your EDA.csv file down into the windows/steps you want to calculate features for. For example, the EDA signal on the E4 samples at 4hz. So if you wanted features for 10 minute windows with a 5 minute step size then you'd do something like:
The most appropriate window size and step size really depends on your use case and what you're trying to predict. In general I'd say having a step size that is half of your window size is a good heuristic. That will let you stretch your data a little bit further so long as you're careful that overlapping windows don't get split between training and test. To figure out window size you'll just need to test different sizes. |
Yeah, good idea. Why don't you email me. I believe you can get my email address from my GitHub profile. If this isn't the case let me know. |
After reviewing your code more it appears that most of the functionality claimed in the paper is missing.
https://www.sciencedirect.com/science/article/pii/S0169260721005356
Are there plans to fix this?
The text was updated successfully, but these errors were encountered: