Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all path inclusion logic into the Path Classifier Class #192

Open
jcampbell05 opened this issue Dec 28, 2018 · 0 comments
Open

Collect all path inclusion logic into the Path Classifier Class #192

jcampbell05 opened this issue Dec 28, 2018 · 0 comments

Comments

@jcampbell05
Copy link
Collaborator

One thing I've noticed is over time we've ended up with logic for detecting which paths should be included in two spots.

For example here:
https://github.com/igor-makarov/xcake/blob/master/lib/xcake/generator/target_file_reference_generator.rb#L23

and here:
https://github.com/igor-makarov/xcake/blob/master/lib/xcake/path_classifier.rb

We should probably make sure or code to do we determining if a file should be included should belong in one class so then it's easy to determine when Xcake includes a file at one glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant