Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce colonCombo field type #180

Open
tordans opened this issue Jan 28, 2025 · 0 comments
Open

Introduce colonCombo field type #180

tordans opened this issue Jan 28, 2025 · 0 comments

Comments

@tordans
Copy link
Collaborator

tordans commented Jan 28, 2025

There are tagging practices that extend the key with a number in order to simulate an array of values.

Similar solutions (Docs):

  • The semiCombo uses semicolons to simulate the array:
     foo=bar;baz
    
  • The multiCombo encodes the value (from a defined list of values) into the key:
    foo:bar=yes
    foo:baz=yes
    

In the case of the panoramax key, the semiCombo is limiting the number of images to about 6 due to each panoramax value and and the max length of the field. See openstreetmap/id-tagging-schema#1344 (comment)

The multiCombo is not used for this kind of tagging where the value is something unique.

Instead MapComplete adds numbers to the key:

panoramax=123,
panoramax:0=234
panoramax:1=345

Historically, there where other cases where this :1 key postfix was used but I am not sure if any still exist that are relevant for the tagging schema. Some where fallbacks from TIGER imports AFAIR and some where used for the deprecated parking schema.


I am not sure if this one panoramax use case is worth adding another combo field type. But lets use this issue to find out…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant