Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Central time integrator lags derivatives for AD nodal values #28859

Open
GiudGiud opened this issue Oct 16, 2024 · 1 comment · May be fixed by #28857
Open

Central time integrator lags derivatives for AD nodal values #28859

GiudGiud opened this issue Oct 16, 2024 · 1 comment · May be fixed by #28857
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

Bug Description

It seems when using the adCoupledDot on nodal variables on a nonlinear variable, to set an axuvariable, the values are lagged for AD compared to non AD

Steps to Reproduce

Run the coupled_dots_nodal.i input from https://github.com/idaholab/moose/pull/28857/files with a CentralDifference time integrator

Impact

Wrong values lead to wrong results

[Optional] Diagnostics

No response
@GiudGiud GiudGiud added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Oct 16, 2024
@GiudGiud
Copy link
Contributor Author

was a consequence of #28867, will be patched by #28857

GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 16, 2024
@GiudGiud
Add support for elemental AD time derivatives for auxvariables (using…
c7a8905 
… nonAD version)

Add support for nodal AD time derivatives, with errors for unsupported cases
closes idaholab#28859 refs idaholab#28867
@GiudGiud GiudGiud linked a pull request Oct 16, 2024 that will close this issue
Open
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 17, 2024
@GiudGiud
Add support for elemental AD time derivatives for auxvariables (using…
e71c341 
… nonAD version)

Add support for nodal AD time derivatives, with errors for unsupported cases
closes idaholab#28859 refs idaholab#28867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finish support for AD time derivatives of dofs GiudGiud/moose
1 participant
@GiudGiud