New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of `using namespace libMesh;` in `Moose.h` #28499

Open

dschwen opened this issue Aug 29, 2024 · 0 comments · May be fixed by #28842

Labels

C: Framework T: task

Member

dschwen commented Aug 29, 2024

Motivation

We should never be putting a using namespace in the global scope in a header file. This pollutes the entire project and can create ambiguities between libMesh and other third party libraries. I just ran into a case where both libMesh and neml2 have a print_helper function with similar signatures. The neml2 version is called from within the neml2 namespace, but due to the using namespace libMesh directive in Moose.h the libMesh version of that function now is an ambiguous alternative for the compiler.

Design

A workaround would be to ask the NEML2 developer to explicitly add a scope resolution operator (call neml2::print_helper instead). But that would look redundant on the NEML2 side, and were asking someone else to fix a problem we created.
I realize we have a ton on types and function that we pull in from the libMesh namespace (starting with simple things like Real or dof_id_type), and addinglibMesh:: everytime we use those would clutter up our code. But we can be more specific with our using statements (e.g. using libMesh::Real in MooseTypes.h etc.).
This would be a laborious effort... #technicaldebt @loganharbour

Impact

Reduce global namespace pollution

The text was updated successfully, but these errors were encountered:

dschwen added the T: task label

lindsayad added the C: Framework label

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

91067a5

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

858662c

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

8f0543a

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

8018a7f

rfs idaholab#28499

GiudGiud linked a pull request

that will close this issue

Remove using namespace libMesh #28842

Open

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

44123dd

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

666fc31

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

c493be4

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

c220ff9

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

00ffbb5

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

ef634c7

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

fb6d573

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

4a10f95

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

699c0be

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

1cdcad7

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

f3287bc

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

7d0d88a

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

5a2bf63

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

8c77099

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

be0285e

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

580fc9d

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

5ff5aac

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

cf2ca0e

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

7ff3daa

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

d07ade6

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

11d9a09

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

b82415e

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

fa27d82

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

d092b54

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

fcea6b0

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/falcon that referenced this issue


          Use libmesh namespace in code that uses it implicitly

f28e755

Format code with clang format
refs idaholab/moose#28499

GiudGiud mentioned this issue

Use libmesh namespace in code that uses it implicitly idaholab/falcon#148

Merged

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

266ab50

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

6205ea6

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

b5b49c6

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

00df7d9

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

befbf9a

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

462f4e0

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

45300bd

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

444cb35

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

267f54c

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

0975c90

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

3c6f6e0

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

c8f6b0e

rfs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework: mostly headers

7e6286d

- declare sub-namespaces of libMesh as their own namespaces
- add libMesh:: in front of many objects
- add using libMesh::many_common_ones
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Remove libMesh namespace from framework source:

8faebe0

- heavily rely on using namespace libMesh
- for some files, add libMesh:: everywhere
refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt framework test objects to libMesh namespace removal

e5ffd5f

refs idaholab#28499

GiudGiud added a commit to GiudGiud/moose that referenced this issue


          Adapt modules to removal of libMesh namespace

78ca384

rfs idaholab#28499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment