Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line number from source data file to import script and database #2

Open
epoz opened this issue Apr 25, 2021 · 0 comments
Open

Add line number from source data file to import script and database #2

epoz opened this issue Apr 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@epoz
Copy link
Contributor

epoz commented Apr 25, 2021

Add a facility to the make_import.py script to record the line number in the notations.txt file being used, and record that in the resulting iconclass.sqlite file.
The database schema should also be updated to accommodate this, plus the commit hash of the repo being used.

These line numbers and the data repo commit hash can then be used to create links in a UI to display an exact reference to the end-user to invite them to view the sources.

@epoz epoz added the enhancement New feature or request label Apr 25, 2021
hansaticonclass added a commit that referenced this issue May 5, 2021
updating the key files in hansaticonclass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant