Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to be more specific at step 'Enable kotlin parcelize' #24

Open
ovitrif opened this issue Apr 7, 2021 · 5 comments
Open
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ovitrif
Copy link

ovitrif commented Apr 7, 2021

This step in documentation doesn't provide information where to apply the plugin:

Enable kotlin parcelize:

I guess it refers to the main application module (usually the app module in an Android application).

@Alex009
Copy link
Member

Alex009 commented Apr 8, 2021

you should enable plugin in gradle module where used moko-parcelize annotations.

@Alex009 Alex009 added the documentation Improvements or additions to documentation label Jun 5, 2021
@Alex009 Alex009 modified the milestone: 0.7.0 Jun 5, 2021
@ovitrif
Copy link
Author

ovitrif commented Mar 1, 2022

you should enable plugin in gradle module where used moko-parcelize annotations.

Hey @Alex009 !
Thank you for answering the issue and the info on how to do this. I didn't create the issue for me, after a lot of digging around I found how to do it before actually creating the issue.

It just felt for me this could be a problem for other fellow devs when integrating the plugin 😉

@ovitrif
Copy link
Author

ovitrif commented Mar 1, 2022

@anton6tak Since this is already assigned to yourself, do you plan to work on it in the near future? Otherwise I'd be happy to submit a PR myself for it 🙇

@Alex009
Copy link
Member

Alex009 commented Mar 1, 2022

@ovitrif it will be great if you submit PR :) thanks

@ovitrif
Copy link
Author

ovitrif commented Mar 1, 2022

Thank you @Alex009! I will 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants