New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cosmological parameters configurable #25

Open

itaboada opened this issue Feb 11, 2021 · 1 comment

Labels

Collaborator

itaboada commented Feb 11, 2021

Currently Omega_M, Omega_Lambda and h_0 are hardcoded on Evolution.py

This is not high priority for neutrino astrophysics, to be honest. Many theorists simply do 0.3, 0.7 and 0.7

itaboada added the enhancement label

Contributor

renereimann commented Feb 25, 2021

Hej Ignacio,
I guess the cosmological parameters are already configurable.
See https://github.com/icecube/FIRESONG/blob/base/Evolution.py#L301
When you construct the LuminosityEvolution you can give it a cosmology dictionary that takes the settings for the cosmological parameters. The default is to use the parameters defined in https://github.com/icecube/FIRESONG/blob/base/Evolution.py#L6.

The cosmological parameters are propagated through and are an attribute of the classes.

The only missing thing is to add an argparse option for the executable scripts to modify it.

mjlarson mentioned this issue

Astropy vs CosmoloPy #36

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment