Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CheckValve using quintic Hermite spline interpolation #1937

Closed
AntoineGautier opened this issue Oct 11, 2024 · 0 comments
Closed

Refactor CheckValve using quintic Hermite spline interpolation #1937

AntoineGautier opened this issue Oct 11, 2024 · 0 comments
Assignees

Comments

@AntoineGautier
Copy link
Contributor

We've experienced some NL solver convergence failures that point to the check valve model:
lbl-srg/modelica-buildings#4002
This ticket is to revise the implementation using a similar approach as the pressure-independent actuator models, based on a quintic Hermite spline interpolation (C2) between the closed valve flow function and the fully open valve flow function.
Initial tests with this new formulation show that all convergence issues are eliminated on the models from the above thread (with minor but favorable impact on simulation time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants