Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping mastarm #819

Open
BaDo2001 opened this issue Jul 20, 2022 · 3 comments
Open

Dropping mastarm #819

BaDo2001 opened this issue Jul 20, 2022 · 3 comments

Comments

@BaDo2001
Copy link

Hey guys!

Is there any reason why you are using mastarm as your build tool? It doesn't seem reasonable as it is barely used and seems obsolete.

@miles-grant-ibigroup
Copy link
Contributor

Hello!

We use Mastarm mostly out of historical reasons. From what I can gather, the tool was built around the same time datatools was built and it was built with datatools in mind. Removing our dependency on it is something I'd like to see, but it's competing with other priorities. If you have a strong alternative, we welcome suggestions and PRs!

Is there an issue you're facing when trying to use mastarm?

Hope this is helpful and please feel free to reach out with any other questions or comments!

@BaDo2001
Copy link
Author

Thanks for the quick reply!

The main issue we are currently facing is related to caching. We use react-scripts to build our react projects which uses webpack under the hood and it allows us to name the bundled js file as index.[random-hash].js which prevents the js file being cached by things like cloudflare. Is there any way to achieve this in mastarm?

@miles-grant-ibigroup
Copy link
Contributor

We've had a similar issue when using mastarm in other projects. Our solution there was to patch the mastarm project to export the root component. Mastarm then builds the project with an exported root component which can then be imported by a dummy webpack project. It's not pretty and it makes the build process a pain, but it worked.

If you take a look at https://github.com/ibi-group/datatools-ui/blob/dev/lib/main.js, you'll see all the redux reducers and the main App ready to export! If you modify that file to export those two then you should be able to import them into a dummy react-redux webpack project.

Sorry that this is the best solution right now, but I hope this was helpful! If you have any other questions please feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants