Fix various issues with templates and variables #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@ildar170975 |
|
Hi Paul. |
Fixes iantrich#93, Closes iantrich#119, Closes iantrich#147 (This eliminates the need for iantrich#119 and iantrich#147)
If multiple variables are defined then subsequent variables can currently reference prior variables using `vars['name']` but not just `name`. This enables variables to reference prior variables by name, like templates can.
|
(I merged #148 here, since it is necessary to fix the build issues.) |
|
This looks great! currently running this pr with no issues. |
oddlama
reviewed
Jan 28, 2025
| config[key] = this._evaluateConfig(value); | ||
| }); | ||
| } else if (typeof config === 'string' && config.includes('${')) { | ||
| return _evaluateTemplate(config); |
There was a problem hiding this comment.
did you mean this._evaluateTemplate? I'm getting a compile error here.
| return eval(template.substring(2, template.length - 1)); | ||
| } | ||
|
|
||
| template.match(/\${[^}]+}/g).forEach(m => { |
There was a problem hiding this comment.
the match may be null giving another compile error. can we maybe do this?
const matches = template.match(/\${[^}]+}/g);
if (matches) {
matches.forEach(m => {
const repl = eval(m.substring(2, m.length - 1));
template = template.replace(m, repl);
});
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.
Fixes #93, Closes #110, Closes #119, Closes #147, Closes #148
(This includes/supersedes #110 and #148, and eliminates the need for #119 and #147)