Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB storage : storing hashes along with the commitment #60

Open
thomas-quadratic opened this issue May 16, 2024 · 0 comments
Open

DB storage : storing hashes along with the commitment #60

thomas-quadratic opened this issue May 16, 2024 · 0 comments

Comments

@thomas-quadratic
Copy link
Contributor

Currently, commitments' scalars are stored inside the children nodes in memory and in database.
However, for generating proofs, we need to get all scalars either way.
We propose to store them along the commitment in the database at the parent node.

To minimize refactoring for now, the idea would be for a StoredNode's NodeFactory to retrieve the parent node info + children hashes from DB, create the parent node, and distribute the children hashes to the children.
This way, a proof generation will not need to load the children node only to retrieve hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant