chore: use crypto-bigint instead of ursa #207
Conversation
Signed-off-by: blu3beri <[email protected]>
| })?)) | ||
| impl From<&str> for LinkSecret { | ||
| fn from(value: &str) -> Self { | ||
| Self(U256::from_be_hex(value)) |
There was a problem hiding this comment.
This will panic on bad input, which doesn't seem ideal. I've been decoding the hex to bytes and using U256::from_be_slice but crypto-bigint could use fallible methods for this.
|
@andrewwhitehead I have been running into some small issues between converting a U256 bigint to an ursa master secret. Right now, I am doing quite a hacky way of serializing a link_secret, U256, into json and deserializing it into a master_secret, openssl bignum. Openssls bignum in JSON is represented as a decimal, but the U256 defaults to lower_le_hex. Do you know of a way to fix this? There are some libraries which can convert between hex strings and decimal strings, which might be fine for now as this is a very temporary solution, but I might be missing some better conversion. |
|
Added a PR for decimal support, although it might still need some changes: RustCrypto/crypto-bigint#246 |
|
@andrewwhitehead #237 makes this redundant, correct? |
|
Yep I don't think it's needed. |
closes #202
partially
resolves#203