Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt | Importing CSV might have performance issue when persisting entities on database. #7550

Open
Joao-vi opened this issue Dec 16, 2024 · 0 comments

Comments

@Joao-vi
Copy link
Collaborator

Joao-vi commented Dec 16, 2024

Describe the bug
After fix bug related to import csv #7525 I've gathered some performance measurements to see impacts from this new fix when persisting on database.

I'm importing just one Entity and increasing numbers of languages installed on the instance.

// entities.saveMultiple (This is the reference, with relationship bug)
Entities Languages: 2 | Time: 50 milliseconds
Entities Languages: 4 | Time: 66 milliseconds
Entities Languages: 6 | Time: 104 milliseconds

// entities.save (Parallel save, with entity conflicts)
Entities Languages: 2 | Time: 235 milliseconds
Entities Languages: 4 | Time: 639 milliseconds
Entities Languages: 6 | Time: 925 milliseconds

// entities.save (Sequential save, without entity conflicts)
Entities Languages: 2 | Time: 463 milliseconds
Entities Languages: 4 | Time: 787 milliseconds
Entities Languages: 6 | Time: 1245 milliseconds

The api entities.saveMultiple, previous used to persist translated versions of the Entities was not applying relationship type correctly on translated version of the entities and therefore persisting metadata properties without the values from the parent relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants