Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IX] - Statuses revamp #7085

Closed
Tracked by #6791
txau opened this issue Aug 1, 2024 · 5 comments · Fixed by #7385 · May be fixed by #7200
Closed
Tracked by #6791

[IX] - Statuses revamp #7085

txau opened this issue Aug 1, 2024 · 5 comments · Fixed by #7385 · May be fixed by #7200

Comments

@txau
Copy link
Collaborator

txau commented Aug 1, 2024

Putting it all together from: #6979 #6977 #7060 #7066

Filters should look like:

LABELED (X%) ............... amount (Accuracy somewhere)
NON LABELED (X%) ............................ amount

Match ............. amount
Mismatch .............. amount

(OTHERS)
Obsolete ...............amount
Error.......................amount

We need to give support for "labeled as empty". Uwazi needs to send these empty markers along with the rest of the training data. If a property has no value, but it also does not have the empty marker, we do not send it to training.

Statuses are display on the table as:

  • IF it is a select/rel field => "X values | X suggestions | X mismatching" (as it is now)
  • IF it is a text/num/date => as it is now
  • Labeled as empty/suggested empty becomes an explicit special case. It is not the same as an empty string. It will come like that from models and we will send it like that to models. So we can have a special icon or pill and it can say "empty" | "empty" or whatever.
  • Error
  • Obsolete

Models will control what comes as "segment", which can contain either the context or some other message, to be display in the column in the table. Ie. if there was an error, that row will contain the status "Error" along with the context "Couldn't read PDF file" or whatever the model decides. We don't need to run any logic on the rendering of the context, just print whatever the model is sending, if it is a blank string, so be it.

@txau
Copy link
Collaborator Author

txau commented Aug 1, 2024

A note on the behavior and updates of the stats panel:

  • When the users clicks "Find suggestions", all suggestions become obsolete. It needs to be reflected on the panel and the table.
  • Every tick of the training/getting suggestions process needs to update the panel and the table.
  • When a suggestion gets accepted on the table, it needs to update the filter panel.

@juanmnl
Copy link

juanmnl commented Aug 14, 2024

We are removing some styles to drive towards a cleaner/simpler "stats & filters" drawer. (these styles will propagate in the future towards all of the existing and future drawers/sidepanels, including the most important ones in library and entity v2)

As discussed with @txau we are removing the "others" title and some percentage values.

stats   filters

Designs

@RafaPolit
Copy link
Member

Just to keep info here:
Accuracy should be defined as:
Match / Mismatch, excluding those mismatches where the entity data is blank or empty string (not intentionally empty)

@RafaPolit RafaPolit mentioned this issue Sep 3, 2024
7 tasks
@konzz konzz self-assigned this Sep 4, 2024
@txau
Copy link
Collaborator Author

txau commented Sep 4, 2024

An addition to this. After a conversation with @gabriel-piles we are going to remove the constraint of having selection rectangles to be considered labeled data for property types "text", "number" and "date". So now they can be used the same as selects, meaning that, if they have a value or they are labeled as empty, then they are considered labeled data. If they are just empty string without explicit "label as empty" then it is not labeled data.

This goes along the line of what @konzz was pointing out for the match/mismatch. If it is labeled (has a value or explicit empty) it goes into the match/mismatch stats.

@txau
Copy link
Collaborator Author

txau commented Sep 27, 2024

In this case obsolete and error have overlapping (two errors are also obsolete). Moreover, they are also counted as mismatch.
image

This was referenced Oct 18, 2024
@daneryl daneryl removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment