Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Send message" to People cards #257

Open
marc-farre opened this issue Mar 25, 2022 · 11 comments · May be fixed by #258
Open

Add "Send message" to People cards #257

marc-farre opened this issue Mar 25, 2022 · 11 comments · May be fixed by #258
Assignees

Comments

@marc-farre
Copy link
Contributor

What do you think about adding a "Send message" button to the cards in the People page?
image

If you agree with this idea, I can send a PR adding an event to add an item on PeopleActionButtons widget.

@luke-
Copy link
Contributor

luke- commented Mar 25, 2022

@orangiene Can you please take a look here? Do we have a concept regarding the button colors/types for cards?

@orangiene
Copy link

I like the idea, let's do it.
Button colors unfortunately do not follow a uniform logic at the moment.
It is especially important that the user can "Follow" - that would be primary color for me. While sending a message has rather smaller prio, therefore secondary color.

@marc-farre
Copy link
Contributor Author

Thanks @orangiene . As the buttons' type list is https://github.com/humhub/humhub/blob/master/protected/humhub/widgets/BootstrapComponent.php#L47, can I use default for secondary color? On Humhub community theme, the default color is #f3f3f3, which is quite close to the secondary color which is #7a7a7a.

@marc-farre
Copy link
Contributor Author

@luke- #258 but because of this problem: humhub/humhub#5622
See my comment on the PR.

@luke- luke- linked a pull request Mar 31, 2022 that will close this issue
marc-farre added a commit to marc-farre/mail that referenced this issue Apr 4, 2022
@marc-farre
Copy link
Contributor Author

@luke- We have an unresolved discussion here: #258 (comment)
The problem was to determine the number of buttons.
Once we've decided, I'll create a new PR on the current develop branch.
Thanks!

@luke- luke- assigned Eladnarlea and unassigned orangiene Nov 29, 2023
@Eladnarlea
Copy link

@luke- @marc-farre I think it's a great opportunity to use an icon button that could turn into a floating button in the future. What do you think about it?

Screenshot 2023-12-12 at 11 18 41 AM

@marc-farre
Copy link
Contributor Author

@Eladnarlea Thanks! Yes, I think it's a very good idea.
@luke- Should I create a PR for this?

@luke-
Copy link
Contributor

luke- commented Dec 12, 2023

What about a menu like this?
image

@Eladnarlea
Copy link

@luke- a menu like this is less intuitive than the icon button. Also for mobile it is less practical.

@luke-
Copy link
Contributor

luke- commented Dec 13, 2023

@Eladnarlea I see your point, but for me the people cards are a bit bloated.

image

If we had a "hidden" decent menu, we could also put other additional not that important options (Block, Edit as Admin, ...) in there.

Maybe we could also:
image


Or without a new menu: We could always display the mail symbol at the bottom (and either +Friends or +Follow - depending on the HumHub configuration. It's confusing for many users anyway, the difference between follow/friends)


For me, however, the solution with the "message" button at the top would also be fine. Even if it's not my favorite.

@Eladnarlea
Copy link

If we had a "hidden" decent menu, we could also put other additional not that important options (Block, Edit as Admin, ...) in there.

I would advise against applying too many options to each page of the software. We should first define what the "people cards" are for and what you can do on the page. Blocking, for example, is a fairly specific action that is rarely used in mass processing. So I don't think it's necessarily relevant to the People Cards page.


Or without a new menu: We could always display the mail symbol at the bottom (and either +Friends or +Follow - depending on the HumHub configuration. It's confusing for many users anyway, the difference between follow/friends)

I like this, I think it's also confusing and we should offer either/or. "Follow" is also an action that should be configured when on the specific profile.


For me, however, the solution with the "message" button at the top would also be fine. Even if it's not my favorite.

@luke- let me think of another way to deal with the "bloated" cards, I would like to provide a different approach.

@mbumpalumpa mbumpalumpa removed their assignment Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants