Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pngquant is no longer needed #167

Closed
johnbillion opened this issue Nov 1, 2023 · 1 comment · Fixed by #174
Closed

pngquant is no longer needed #167

johnbillion opened this issue Nov 1, 2023 · 1 comment · Fixed by #174

Comments

@johnbillion
Copy link
Member

Tachyon uses pngquant to compress PNG files, but this hasn't been needed since Sharp 0.28 which includes built-in support for generating compressed palette PNGs.

Ref: lovell/sharp#478 (comment)

This means the separate pngquant processing in Tachyon could be replaced with the palette argument for Sharp.
@joehoyle
Copy link
Member

Nice find @johnbillion !

joehoyle added a commit that referenced this issue Nov 20, 2023
@joehoyle
Remove PNG Quant
c614130 
Sharp has this built in now

Fixes #167
@johnbillion johnbillion linked a pull request Nov 20, 2023 that will close this issue
Remove pngquant #170
Closed
@joehoyle joehoyle mentioned this issue Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pngquant humanmade/tachyon
Remove pngquant humanmade/tachyon
2 participants
@joehoyle @johnbillion