-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better HTTP Status Code for Empty Requests #365
Comments
Related langgenius/dify#6807 |
??? |
Hey @OlivierDehaene, could you please elaborate as to what's the issue with the description? I hope it's nothing offensive, as I was just trying to describe it in a light-hearted manner. If that's not the interpretation, I apologize and can edit it to be more formal. |
@OlivierDehaene The returned 413 error for too large requests: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_client_errors Besides it being incorrect one for empty requests, it makes finding the actual issue harder (e.g. if one has large cluster with large number of requests flying around, and that error code only bubbles up to some higher level report). |
System Info
(I don't think it's necessary)
Information
Tasks
Reproduction
Expected behavior
HTTP status 400 is more appropriate IMHO. The 413 status code might lead to misinterpretation. For example, when integrated with Dify, dify translates the 413 to Payload too large, but there is not payload to begin with.
The text was updated successfully, but these errors were encountered: