Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListRequestOptions should know how to compose it's own querystring #91

Open
Psypher9 opened this issue Oct 9, 2020 · 1 comment
Open

ListRequestOptions should know how to compose it's own querystring #91

Psypher9 opened this issue Oct 9, 2020 · 1 comment
Assignees
@Psypher9
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Psypher9
Copy link
Member

Psypher9 commented Oct 9, 2020

Is your feature request related to a problem? Please describe.
Currently when using ListRequestOptions, our pattern is to use a bunch of repetitive code to set the query params for each individual request, over and over ad nauseum. Example:

image

This happens over and over, but we use the same ListRequestOptions, so all options are already held internally.

Describe the solution you'd like
Instead of being repetitive, we should build the ListRequestOptions in such a way that it knows how to build it's own query string and that string is then appended to the request URI.
@Psypher9 Psypher9 added enhancement New feature or request help wanted Extra attention is needed labels Oct 9, 2020
This was referenced Oct 9, 2020
Closed
Merged
@Psypher9
Copy link
Member Author

Psypher9 commented Oct 9, 2020

Being handled in e0795ea..634cc5b and on psypher9/91

@Psypher9 Psypher9 self-assigned this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Psypher9 Psypher9

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Psypher9