You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GitHubAbuseLimitHander and GitHubRateLimitHandler both implement parseWaitTime. Most of the code is the same and could also be useful to consumers of this library.
Extract parseWaitTime to a utility class and consider exposing as public.
The text was updated successfully, but these errors were encountered:
I would like to refactor the parseWaitTime method from both GitHubAbuseLimitHandler and GitHubRateLimitHandler into a utility class and potentially make it public for reuse. If that's okay with you, would it be alright for me to go ahead and try this approach? Please let me know if you have any concerns or suggestions.
@bitwiseman seman Hi, I am a beginner and I have a question regarding this issue. Is it necessary to create a new utility class to extract the parseWaitTime method, or could we solve this problem in another way? Thank you!
@bitwiseman seman Hi, I am a beginner and I have a question regarding this issue. Is it necessary to create a new utility class to extract the parseWaitTime method, or could we solve this problem in another way? Thank you!
GitHubAbuseLimitHander
andGitHubRateLimitHandler
both implementparseWaitTime
. Most of the code is the same and could also be useful to consumers of this library.Extract
parseWaitTime
to a utility class and consider exposing aspublic
.The text was updated successfully, but these errors were encountered: