Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract parseWaitTime method to shared utility #1973

Open
bitwiseman opened this issue Oct 14, 2024 · 3 comments
Open

Extract parseWaitTime method to shared utility #1973

bitwiseman opened this issue Oct 14, 2024 · 3 comments

Comments

@bitwiseman
Copy link
Member

bitwiseman commented Oct 14, 2024

GitHubAbuseLimitHander and GitHubRateLimitHandler both implement parseWaitTime. Most of the code is the same and could also be useful to consumers of this library.

Extract parseWaitTime to a utility class and consider exposing as public.

@choichanhyeok
Copy link
Contributor

I was thinking of trying to work on this issue.

I would like to refactor the parseWaitTime method from both GitHubAbuseLimitHandler and GitHubRateLimitHandler into a utility class and potentially make it public for reuse. If that's okay with you, would it be alright for me to go ahead and try this approach? Please let me know if you have any concerns or suggestions.

@shivangi-jindal
Copy link

@bitwiseman seman Hi, I am a beginner and I have a question regarding this issue. Is it necessary to create a new utility class to extract the parseWaitTime method, or could we solve this problem in another way? Thank you!

@bitwiseman
Copy link
Member Author

@bitwiseman seman Hi, I am a beginner and I have a question regarding this issue. Is it necessary to create a new utility class to extract the parseWaitTime method, or could we solve this problem in another way? Thank you!

What other way would you like to solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants