Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper backend #1

Closed
yoshuawuyts opened this issue Nov 19, 2019 · 4 comments
Closed

Hyper backend #1

yoshuawuyts opened this issue Nov 19, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yoshuawuyts
Copy link
Member

In https://github.com/http-rs/surf/blob/8cf05e347404abbb091b80f809a5e1a354c6c735/src/http_client/hyper.rs we have a hyper 0.12 backend that unfortunately doesn't quite work. I fumbled something up during release, and never quite fixed it. But now it seems there may still be a few issues to resolve.

It'd be nice if we could port it back here, and restore it under the hyper-client flag. Note that this should be based on Hyper 0.12, and not any of the alphas as a lot of it still seems to be in flux. Thanks!

@yoshuawuyts yoshuawuyts added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2019
@goto-bus-stop
Copy link
Member

hyper 0.13 is officially out now, so this should use it over 0.12 probably!

@calvinbrown085
Copy link

calvinbrown085 commented Feb 26, 2020

I assume this would be adding something similar to https://github.com/http-rs/http-client/blob/master/Cargo.toml#L18 here.

Something like
hyper_client= ["hyper-client]
?

I'm willing to help pick this one up if I could help get it across the finish line :)

@bspeice
Copy link
Contributor

bspeice commented Aug 9, 2020

I think this can be closed now that #32 is merged?

@goto-bus-stop
Copy link
Member

looks that way, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants