Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks your octane app - be careful #103

Open
BryanCrotaz opened this issue Apr 15, 2021 · 6 comments
Open

Breaks your octane app - be careful #103

BryanCrotaz opened this issue Apr 15, 2021 · 6 comments

Comments

@BryanCrotaz
Copy link

With ember-hammertime installed:

Template Compiler Error (TemplateCompiler) in lords-fielder-tool/application/template.hbs

Cannot read property 'start' of undefined
@BryanCrotaz BryanCrotaz mentioned this issue Apr 15, 2021
Open
@wmlele
Copy link

wmlele commented Apr 16, 2021

Same. Application breaks from 3.25.+ onwards.

@jking6884
Copy link

Same. Upgraded to 3.26 and getting the same TemplateCompile error

@jdurand jdurand mentioned this issue Jun 13, 2021
Closed
@rreckonerr
Copy link

3.24 is affected too

@rreckonerr
Copy link

rreckonerr commented Nov 20, 2021 •
edited
Loading

Hi, @rwwagner90
Tagging you as the last person that committed to this repo. Do you know if this repo is still maintained? It'd be great to update dependencies (especially "ember-cli-babel" that breaks the build for ember apps 3.2x+)

@RobbieTheWagner
Copy link
Member

@rreckonerr it is my understanding that hammertime has not been needed for years. It was only to remove the delay from touch events, but that has been fixed in mobile browsers for awhile. Is anyone here still experiencing the delays and actually need the package or is it a leftover dependency?

@rreckonerr
Copy link

@rwwagner90 Thanks for a quick reply!
It seems like the 300ms delay has been removed in Chrome 32+. https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away
I've removed the ember-hammertime addon already and don't see any downsides yet.

davidtaylorhq added a commit to davidtaylorhq/guides-source that referenced this issue Nov 9, 2022
@davidtaylorhq
Remove ember-gestures addon recommendation
7c489b6 
`ember-gestures` and its dependency, `ember-hammertime`, are no longer maintained and do not function at all on recent versions of Ember.

Refs:
- html-next/ember-gestures#139
- html-next/ember-hammertime#103
@davidtaylorhq davidtaylorhq mentioned this issue Nov 9, 2022
Merged
BlueCutOfficial pushed a commit to DazzlingFugu/ember-fr-guides-source that referenced this issue Jan 27, 2023
@davidtaylorhq @BlueCutOfficial
Remove ember-gestures addon recommendation
ba99c37 
`ember-gestures` and its dependency, `ember-hammertime`, are no longer maintained and do not function at all on recent versions of Ember.

Refs:
- html-next/ember-gestures#139
- html-next/ember-hammertime#103
BlueCutOfficial added a commit to DazzlingFugu/ember-fr-guides-source that referenced this issue Jan 27, 2023
@BlueCutOfficial @jaredgalanis
@wagenet @NullVoxPopuli @mansona @davidtaylorhq @jenweber @geneukum @dknutsen @MinThaMie @GreatWizard @MrChocolatine
Build/ Back to app + v4.10 (#162)
e5bdb9e 
* v4.8.0

* Designate rfcs.emberjs.com as the source of truth for RFCs

* Update index.md

* Add dictionary changes

* Add formatters

* Fix errors

* stop outputting `no issues found` on every file

* Remove `ember-gestures` addon recommendation

`ember-gestures` and its dependency, `ember-hammertime`, are no longer maintained and do not function at all on recent versions of Ember.

Refs:
- html-next/ember-gestures#139
- html-next/ember-hammertime#103

* v4.9.0

* Update setupTest function imports

* Add SkoebaSteve's changes to other guides versions (#1890)

SkoebaSteve updated the helpers content for v4.5
to cover how to use local helpers. This commit copies
those changes into more recent guides versions as well.

Co-authored-by: Steef Janssen <[email protected]>

Co-authored-by: Steef Janssen <[email protected]>

* controllers: fix broken link to API docs

The link to the Controller API docs is broken, so when anyone clicks it
they'll be met with a 404 error. Let's fix up that link so that the user
navigates to the top level of the Controller API docs instead (as this
link did up until 4.8).

This closes ember-learn/guides-source#1880.

* Update autotracking in-depth guides to use @cached decorator (#1886) (#1887)

* v4.10.0 (#1892)

* setup: remove all historical versions

* feat: setup project to use guide-sources internally (#4)

* feat: setup project to use guide-sources internally

* fix: apply suggestions from code review

Co-authored-by: Marine Dunstetter <[email protected]>

Co-authored-by: Marine Dunstetter <[email protected]>

* Docs/ update and translate `README.md` (#5)

* docs: update readme.md

* docs: add LISEZMOI.md

* docs: apply review suggestions to lisezmoi.md

Co-authored-by: MrChocolatine <[email protected]>

Co-authored-by: MrChocolatine <[email protected]>

* Checkout upstream and go back to a full app

Co-authored-by: Jared Galanis <[email protected]>
Co-authored-by: Peter Wagenet <[email protected]>
Co-authored-by: NullVoxPopuli <[email protected]>
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: David Taylor <[email protected]>
Co-authored-by: Jen Weber <[email protected]>
Co-authored-by: Steef Janssen <[email protected]>
Co-authored-by: Geordan Neukum <[email protected]>
Co-authored-by: Dan Knutsen <[email protected]>
Co-authored-by: Anne-Greeth Schot-van Herwijnen <[email protected]>
Co-authored-by: Guillaume Gérard <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wmlele @BryanCrotaz @RobbieTheWagner @jking6884 @rreckonerr