Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personalized vs project config #86

Open
3 tasks
janiswehen opened this issue Jun 29, 2022 · 0 comments · May be fixed by #100
Open
3 tasks

personalized vs project config #86

janiswehen opened this issue Jun 29, 2022 · 0 comments · May be fixed by #100
Assignees
Labels
story 📚 User stories are short, simple descriptions of a feature.

Comments

@janiswehen
Copy link
Contributor

janiswehen commented Jun 29, 2022

Problem to solve

As Squeak Developer working in a Team, I want the saved source to be poppyPrinted with a Project specific config, but still want to see the source in my browser poppyPrinted with my personalized config so that all teammembers with different personalized configs have still the same source code and no unnessecary changes that make it in the commits.

Further details

The personalized config can for now be the default Config returned by a class Method PPFormatterConfig personalizedConfig. This Method can be specialized in an other Issue further down the line.
The project specific config should be specified in a Method in the Project. There are many options for this implementation. One possibility could be a Method with a Pragma <ppProjectConfig> that can be found via the Pragma. One example could be

ppProjectConfig
	<ppProjectConfig>

	^ PPFormatterConfig default
		spacesBeforePointInArray: true;
		formatToMaxLineWidth: true;
		maxLineWidth: 120

If no Method with this Pragma is found in the Project then the project specific config is PPFormatterConfig default.

Acceptance Criteria

  • Given the project specific config. When I have prettyprint selected in the browser and press save then it gets saved poppyPrinted with the project specific config even if its displayed different.
  • Given a personalized Config. When I have prettyprint selected in the browser and press save then I want the displayed method to be poppyPrinted with the personalized Config.
  • When I have source selected in the browser and press save then the displayed Method and the saved Method is not poppyPrinted at all
@janiswehen janiswehen added the story 📚 User stories are short, simple descriptions of a feature. label Jun 29, 2022
@janiswehen janiswehen changed the title Showing method with prefrence config and saving method with package specifig config personalized and project config Jun 29, 2022
@janiswehen janiswehen changed the title personalized and project config personalized vs project config Jun 29, 2022
@kdauer kdauer added proposal 📄 Proposal for new Backlog Items and removed proposal 📄 Proposal for new Backlog Items labels Jun 29, 2022
@kdauer kdauer added this to the Sprint: Jun 29 - Jul 13, 2022 milestone Jun 29, 2022
@kdauer kdauer linked a pull request Aug 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story 📚 User stories are short, simple descriptions of a feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants