Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Documenting new promises in lib/Facebook.js #22

Open
HassenIO opened this issue Nov 21, 2018 · 2 comments
Open

Documenting new promises in lib/Facebook.js #22

HassenIO opened this issue Nov 21, 2018 · 2 comments
Labels
Facebook-related help wanted Extra attention is needed

Comments

@HassenIO
Copy link

HassenIO commented Nov 21, 2018

Hi all, 👋

This follows my current work on "Allow Promises when on Facebook API calls" of botkit, actually still in PR #1520.

I would like to have a first feedback on how to properly document the promise way of some methods, in addition to the classical callback way.

Here is an example, currently in my fork https://github.com/htaidirt/botkit-docs/commit/c8f393ce2739d4c5fc3c7466650cd6608101d351. Given your feedbacks, I'll continue documenting similarly the remaining methods.

Thanks

@HassenIO HassenIO changed the title Documenting new promises in lib/Facebook.js of Botkit Documenting new promises in lib/Facebook.js Nov 22, 2018
@ouadie-lahdioui
Copy link
Collaborator

ouadie-lahdioui commented Dec 13, 2018

Hi @htaidirt, I've taken a look at your fork and it sounds great.

Go Go Go

@ouadie-lahdioui ouadie-lahdioui added Facebook-related help wanted Extra attention is needed labels Dec 13, 2018
@benbrown
Copy link
Contributor

@htaidirt since the promise code has been released, let's get these docs updated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Facebook-related help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants