-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Hood.ie Accessible #28
Comments
Original title: Add ARIA roles and tab index I've changed the title because to make Hood.ie accessible, it may require more work than just ARIA roles and Tab Indexes. I will now try and create a list of things that need to be done, so everyone can take part in making Hood.ie accessible :) |
@verpixelt what did you mean by "add TabIndex" by the way, whats the purpose of doing this? |
ARIA RolesWe need to make sure that the elements within all our With HTML5 came the introduction of semantic elements ( The important thing here is not just to add ARIA roles everywhere, but to consider whether or not they are needed. Something that is helpful is to use HTML5 elements as much as possible, these will indicate which ARIA roles you need and reduces a mass of Pages to be reviewed
|
Navigating to main contentWe have a lot of navigational items in the header that a user must tab through if they are using keyboard-only/ a screenreader. I'm sure that regular visitors to the Hood.ie website would just like to be able to go straight to the main content, so we should implement a skip link for all pages which will take you to the main content. I'm not sure yet which way to implement this, either in a header include that is already injected into each HTML page, or some other way. To do the former, we'd need to ensure that the main content has the same ID or element name so the skip link goes to the same place on each page. A skip link will likely require some JavaScript.
|
Guide to AccessibilityAn accessibility guide should be written to help all contributors think about accessibility from the start when they build components so we do not have to go through the site ever again to do all this work. Accessibility first FTW. The issue for this task is here: hoodiehq/hoodie-css#1
|
DesignThere are a number of improvements that can be made to the design of Hood.ie.
|
Other
|
#mansplain |
To be honest, I think @pcalves answer was great and this is one of the things @Charlotteis asked about. also @zaccolley, I'd love to see more productive comments. This feels kind of passive-agressive. So please, be nice :) If you are not sure what is okay and what not, please take a look at our Code of Conduct: http://hood.ie/code-of-conduct/ |
@zoepage Ugh, now I feel bad for deleting my comment. I guess I was afraid I actually had done something wrong, even when I felt my intentions were good, if that makes sense? So then, tabindex. It's a property that lets the browser know whether an HTML element is focusable. Moreover, it tells the browser in which order elements should be focused as a person tabs through the page. Useful to give tab access to elements that aren't usually focusable by default (such as |
@pcalves thank you for putting it up again :) |
yeah I didn't add anything worthwhile to this, sorry gang |
Hi folks! Though I do know what Tab Index is, having an explanation is great for My question was more the "why do we need to manually set this accross :)
|
Have you tried e.g. to navigate the index page just with tab? After you've passed the main navigation you jump into the left "row" which isn't the first according to the content flow. The first would have to be the middle one, next the left and than the right. There are a few elements on pages where it would make sense to alter the tab index to get the right content flow. |
Honestly, I see no problem with the way that things are tabbed on the main page. For someone interacting with a page, it would be confusing to not go to the left column first and actually start in the center. Visually people read from left to right and I don't think we should change that. Looking at the HTML source they go left - center - right too. I of course don't want to dismiss this completely! But with that example, it doesn't make sense to me and I think it would be a bad change. However, perhaps there is someone better at a11y than me who can jump in and help me understand. |
The middle column tells you what this project is all about, the left one how to install it. It doesn't make sense to read the left one first (+ this was just an example). |
Is there still room for this to be worked on? |
@chrisdemars yes, almost no progress has been made here due to life, work and health. |
Okay, I will start looking in to this issue. On Thu, Mar 3, 2016 at 9:27 AM, Charlotte Spencer [email protected]
|
that’s super awesome, thanks @chrisdemars 👍 |
@Charlotteis @gr2m I just cloned the repo to my machine tonight, I am going to work on some of these a11y issues throughout the week. Is it okay to submit small PR's or one big one? |
@chrisdemars small PRs are perfect, thanks 👍 |
No description provided.
The text was updated successfully, but these errors were encountered: