Preheating support in History Chart #23878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
PREHEATING
was added as anHVACAction
a while ago, but the history charts do not shade the area under the current temperature which they do if theHVACAction
isHEATING
.Original architecture discussion: home-assistant/architecture#710
Original Core PR: home-assistant/core#94677
Original Frontend PR: #16922
Issue: #23876
This PR uses
CLIMATE_HVAC_ACTION_TO_MODE
to map theHVACAction
to a mode in the same way that the thermostat card does to colour the background when heating or cooling. It does mean thatHVACAction.DEFROSTING
is also captured by this change.As a side note, I don't understand why
defrosting
is mapped toheat
, the architectural discussion for defrost specifically says the system is not currently generating heat. In my view,defrosting
should be mapped tooff
, but that would be the topic of a separate discussion.As second side note, on the defrosting discussion there seemed to be some confusion about what preheating means. When a device is heating, it is heating up to a set temperature. When preheating, it is heating to a future set temperature. See the images on the linked issue.
This is my first PR to Home Assistant Core or Frontend, so if I have missed anything let me know.
Type of change
Example configuration
Additional information
hvac_action
ofpreheating
not shown #23876Checklist
If user exposed functionality or configuration variables are added/changed: