Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show header toggle" does not work for covers #23805

Open
4 tasks done
mxr opened this issue Jan 19, 2025 · 6 comments
Open
4 tasks done

"Show header toggle" does not work for covers #23805

mxr opened this issue Jan 19, 2025 · 6 comments

Comments

@mxr
Copy link

mxr commented Jan 19, 2025

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.
  • I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

When I use the 'entities' card with covers and enable 'show header toggle', a toggle doesn't show up.

Describe the behavior you expected

I expect a toggle to show up (for example, it works for lights).

Steps to reproduce the issue

Create a card as follows.

type: entities
entities:
  - entity: cover.living_room_shade
title: Shades
show_header_toggle: true
Image

What version of Home Assistant Core has the issue?

core-2025.1.2

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue?

No response

Which operating system are you using to run this browser?

No response

State of relevant entities

Problem-relevant frontend configuration

type: entities
entities:
  - entity: cover.living_room_shade
title: Shades
show_header_toggle: true

Javascript errors shown in your browser console/inspector

Additional information

Example configuration for lights that works

type: entities
entities:
  - entity: light.living_room_lights
title: Lights
show_header_toggle: true
Image
@Misiu
Copy link
Contributor

Misiu commented Jan 20, 2025

@mxr toggle allows turning something on/off. How would you like it to work with covers?
If you want to control multiple covers using the same buttons you can always create a cover group.

@mxr
Copy link
Author

mxr commented Jan 20, 2025

@Misiu HA already supports open_cover, close_cover, and toggle actions to fully open or close covers. So I would expect the visual switch to work the "same way" and fully open or close covers in the card

@Misiu
Copy link
Contributor

Misiu commented Jan 21, 2025

I think the togglable domains are defined here:

export const DOMAINS_TOGGLE = new Set([
  "fan",
  "input_boolean",
  "light",
  "switch",
  "group",
  "automation",
  "humidifier",
  "valve",
]);

I don't remember that the header toggle worked for covers before, so this is a feature request, not a bug.

@mxr
Copy link
Author

mxr commented Jan 21, 2025

Thank you. Adding cover to that list made the toggle appear but the behavior is a little wonky.

I can fully open and fully close the cover with the toggle. However if I use the arrows to change the state, the toggle doesn't change.

Compare this to lights, where moving the brightness slider switches the toggle between "on" and "off".

For my purposes I am fine with this behavior. Is it acceptable?

@Misiu
Copy link
Contributor

Misiu commented Jan 21, 2025

I'm not the one making the decisions here :)
In my opinion, the behavior would be a bit misleading and many users will create new issue reports here because of that change.
I use cover groups to control multiple covers in specific for at once, you can even add all covers to a group and control them globally.
this way you could add that group on top, then a separator, and below the standard covers.
Just a suggestion.

@mxr
Copy link
Author

mxr commented Jan 21, 2025

In my opinion, the behavior would be a bit misleading and many users will create new issue reports here because of that change.

That's fair

I use cover groups to control multiple covers in specific for at once, you can even add all covers to a group and control them globally.

Thanks, although I am aware of that, I was looking to use the toggle since it's small and built-in to the card (doesn't require using a custom card)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants