bump to pion v4 #109
Open
bump to pion v4 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
reviewed
Oct 16, 2024
| tx5-go-pion = { version = "0.1.3-beta", path = "crates/tx5-go-pion" } | ||
| tx5-signal = { version = "0.1.3-beta", path = "crates/tx5-signal" } | ||
| tx5 = { version = "0.1.3-beta", path = "crates/tx5" } | ||
| tx5-connection = { version = "0.1.4-beta", default-features = false, path = "crates/tx5-connection" } |
There was a problem hiding this comment.
Is this expected to be compatible for use on 0.4? Otherwise we might consider bumping to 0.2.x and leaving room to maintain 0.1.x for 0.4
There was a problem hiding this comment.
It is indeed expected to be compatible.
|
Quick evaluation of test failures lead me to believe the close event changes may have impacted some of our test timings... causing disconnect messages to be received before final messages are received... alas, I'll need to have a more concerted look at this before being able to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESOLVES: #108